Fix jobInfoChips display issue on mobile devices

shredxt commented 2 years ago

On mobile devices currently, the jobInfoChips are overlapping the Job Title, this change resolves this issue. This PR should resolve Issue #468 for Mobile users. I wasn't able to repro the issue in a Desktop environment.

Additions / Removals

Nothing was added or removed, just amended one of the CSS values.

Testing

Tested on Chrome on Android and using Dev Tools Mobile View on Chrome Desktop.

Screenshots

Notes

This flex-direction value can also be defined as 'row' or potentially even be removed entirely since it appears to have no negative effect when removed (see screenshots)? It also has no effect (obviously) on the Desktop site since it is a mobile-only value.

Checklist

[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the contributing guide
[x] Passes all existing automated tests
[x] New functions include new tests
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged
[x] Visually tested in supported browsers and devices

hiqbal01 commented 2 years ago

@shredxt does this still look good on desktops? Also did we try the fix in a couple different browsers?

shredxt commented 2 years ago

This issue was also affecting Desktop users if the window width was below 768px, can confirm that the changes above resolve the issue on Desktop too.

https://user-images.githubusercontent.com/47064656/170066584-b70c9564-db91-4c2e-ba7d-5e4e91d56f81.mp4

Additional testing was done on Firefox on Desktop and Chrome on Mobile.

joshdraha commented 2 years ago

Where is this code located? If I need to add it, what file do I add it to and what is the file path?

joshdraha commented 2 years ago

@hiqbal01 - Where is this code located? If I need to add it, what file do I add it to and what is the file path?

maverick2030 commented 2 years ago

Same problem as the comments above. Where is the file / code located?

joshdraha commented 2 years ago

@maverick2030 @SherpaGreg they won't answer you nor are they any help. I went on Fiverr and found someone to fix the issue.

SherpaGreg commented 2 years ago

Would you mind sharing the Fiverr you found? I actually have a few things I’d like to do to the portal and while I know a little bit of development, I don’t think I can achieve what I’m trying to do.

Thanks!

Greg Whitesell | Marketing Director | 704.374.0001

[Sherpa Email Logo 2019]

From: joshdraha @.> Sent: Tuesday, July 26, 2022 4:45 PM To: bullhorn/career-portal @.> Cc: Greg Whitesell @.>; Mention @.> Subject: Re: [bullhorn/career-portal] Fix jobInfoChips display issue on mobile devices (PR #470)

@maverick2030https://github.com/maverick2030 @SherpaGreghttps://github.com/SherpaGreg they won't answer you nor are they any help. I went on Fiverr and found someone to fix the issue.

— Reply to this email directly, view it on GitHubhttps://github.com/bullhorn/career-portal/pull/470#issuecomment-1195962271, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJCZVXM7T5PKO6EYAQ2TIVTVWBE3ZANCNFSM5VFWFM2Q. You are receiving this because you were mentioned.Message ID: @.**@.>>

joshdraha commented 2 years ago

Here is the link to the guy I used: https://www.fiverr.com/dev_zone/develop-a-custom-wordpress-plugin?source=order_page_summary_gig_link_image&funnel=9475138b60aecb8e84dfb270d5d09db4

margotliberty commented 1 year ago

Well I'm a Bullhorn user with this same issue. Did anyone figure out how to make this correction? Do we know which file needs to be edited and on which line? Any assistance would be greatly appreciated. Thanks!

bullhorn / career-portal