search

bulwarkid / virtual-fido

A Virtual FIDO2 USB Device
MIT License
1.21k stars 55 forks source link

demo: `undefined: platformUSBIPExec` on Linux #20

Closed stefan2904 closed 1 year ago

stefan2904 commented 1 year ago

I cannot run the demo (on the latest master, commit 2ebf6ee061431aa401217e168447a80725e12383) on Ubuntu 22.04.2.

Maybe I am missing something, but when I run sudo go run ./cmd/demo start I get:

# github.com/bulwarkid/virtual-fido/cmd/demo
cmd/demo/server.go:83:11: undefined: platformUSBIPExec

Looks like platformUSBIPExec is only implemented in exec_windows.go?

stefan2904 commented 1 year ago

Using tag v0.2.0 it works. Looks like exec_other.go got deleted in https://github.com/bulwarkid/virtual-fido/commit/ec1d452782f9167749c0acb4cc0db4f3748179d1#diff-e021d23644028fd2cee0fa8a17b5f3b030a88888562248e24353a701476b7c19

cmdli commented 1 year ago

Interesting; that should be implemented in exec_linux.go. Let me take a look. Thanks for the report!

cmdli commented 1 year ago

Alright, this should be fixed with https://github.com/bulwarkid/virtual-fido/commit/7bab84576767a28e5edfea82b68b4ee8ac0ccaae. Looks like a bad .gitignore caused new files in cmd/demo to be ignored, which included the (now added) exec_linux.go and exec_macos.go. Thanks for reporting this; I probably wouldn't have caught it on my machine since the files are there, just not tracked by git.

stefan2904 commented 1 year ago

thanks for the fast fix!

(maybe a simple CI would make sense to catch this kind of mistakes? at least to check if a commit compiles.)