search

bumi / lnme

Your friendly Bitcoin Lightning ⚡ payment page ⚡
MIT License
164 stars 29 forks source link

Docker container #24

Closed AaronDewes closed 2 years ago

AaronDewes commented 2 years ago

The docker images build, but haven't been tested yet.

This adds very early docker container support. Once you merge this PR, builds will automatically happen on every push and tag and will be pushed to GitHub container registry.

junderw commented 2 years ago

LGTM

bumi commented 2 years ago

Yes, sadly that's a problem. at this point we do not have automated tests. it's a tiny app but at least some basic integration specs must be added with adding more features.

AaronDewes commented 2 years ago

Tested & works.

AaronDewes commented 2 years ago

Yes, options get passed in as env vars through docker-compose

bumi commented 2 years ago

OK, I think this is cool.

I can then also do something like: docker run -it --rm ghcr.io/bumi/lnme:master correct? could you add a note to the readme?

AaronDewes commented 2 years ago

Sorry, I missed your comment. I'll add a note now.

bumi commented 2 years ago

thanks so much! merging!