search

bundestag / gesetze-tools

Scripts to maintain German law git repository
GNU Lesser General Public License v3.0
113 stars 21 forks source link

Restore banz scraper and lawgit functionality #18

Closed jbruechert closed 3 years ago

jbruechert commented 3 years ago

Bisher funktioniert von den scrapern nur der banz_scraper (wir bekommen also nur Daten vom Bundesanzeiger). Mir fehlt noch das Hintergrundwissen ob wir damit Gesetzesänderungen verpassen, oder ob auch alles im BAnz veröffentlicht wird

darkdragon-001 commented 3 years ago

We should coordinate our efforts. I have Python3 functionality restored in #17 and am working on the BGBl scraper in #20.

jbruechert commented 3 years ago

This pull request is mostly about the banz scraper, I can probably get the first commit rebased on top of your automated porting work.

ulfgebhardt commented 3 years ago

https://discord.gg/YcQSvKcKB2

jbruechert commented 3 years ago

Can we maybe just open issues for things we are working on? I'd like to avoid having to read yet another chat service.

ulfgebhardt commented 3 years ago

I am totally fine with issues - this is just for convenience, voice & video chat if needed for coordination

jbruechert commented 3 years ago

This should be ready now. At least if you are okay with the added log function in lawgit, which I found useful to debug whether something is happening while it prints the same message multiple times so the console would not visibly change.

jbruechert commented 3 years ago

GitHub seems to be a bit stupid again, on the branch the checks ran just fine, but they are not displayed here: https://github.com/JBBgameich/gesetze-tools/commits/restore-functionality. Is there anything I can do about it?

ulfgebhardt commented 3 years ago

You need to rebase

ulfgebhardt commented 3 years ago

your branch > rebase from master > force push > your branch > profit

jbruechert commented 3 years ago

I already did that, as mentioned, the checks run fine on the branch

ulfgebhardt commented 3 years ago

Maybe thats a security feature to not expose potential secrets. I recommend to work directly on this Repo instead of a fork. I never had this problem before tho...

jbruechert commented 3 years ago

It's a GitHub bug, the new pull request works.

ulfgebhardt commented 3 years ago

I think its about security. If you change the workflow and write a script which would expose a secret to the log it would be bad. But yeahr - makes forks even less usable as they already are - so considering it a bug might be valid ;)

jbruechert commented 3 years ago

I doubt this is a security feature. The workflow ran just fine. The result was just not propagated to the pull request.