Modified dotted_chart_data to use data table

bupaverse / processmapR

Visualize event logs using directed graphs, i.e. process maps.

https://bupaverse.github.io/processmapR/

Other

9 stars 6 forks source link

Modified dotted_chart_data to use data table #33

Closed urvikalia closed 2 years ago

urvikalia commented 3 years ago

Hello, Have tried optimizing the method dotted_chart_data to use a data table. ran a profiler on this method for 1 million records, it took around 17 mins with data frame (existing implementation) whereas 1.5 min with the data table. Kindly have a look and let me know your thoughts.

gertjanssenswillen commented 2 years ago

Thanks for your pull request! - I seemed to have missed it. I'll check and merge it.

gertjanssenswillen commented 2 years ago

@urvikalia thx again. This is now merged with the dev branch, and will be included in the next release. I've added your github username to the description as a contributor. Feel free to let me know if you want to see your actual name there.

urvikalia commented 2 years ago

@gertjanssenswillen Thank you.