Remove exit time destructors from libjingle

[GoogleCodeExporter]

Exit time destructors are like static initializers in reverse: Nondeterministic 
execution order; they cause code to be swapped in at inopportune times (program 
startup / shutdown); they can be racy when accessed from several threads.

http://code.google.com/p/chromium/issues/detail?id=101600#c15 contains a list 
of possible patterns to remove them.

Here's the list of exit time destructors in the version of libjingle used by 
chromium:

third_party/libjingle/source/talk/base/fileutils.cc:157:45: warning: 
declaration requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/helpers.cc:209:38: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/logging.cc:111:36: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/logging.cc:98:29: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/physicalsocketserver.cc:696:40: warning: 
declaration requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/task.cc:200:28: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/task.cc:201:28: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/task.cc:202:28: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/task.cc:203:28: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/task.cc:204:28: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/task.cc:205:28: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/task.cc:206:28: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/base/thread.cc:51:15: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/p2p/base/port.cc:534:20: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/xmllite/xmlconstants.cc:46:22: warning: 
declaration requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/xmllite/xmlconstants.cc:51:16: warning: 
declaration requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/xmpp/xmppengineimpl.cc:43:26: warning: 
declaration requires an exit-time destructor [-Wexit-time-destructors]
third_party/libjingle/source/talk/xmpp/xmpptask.cc:36:18: warning: declaration 
requires an exit-time destructor [-Wexit-time-destructors]

Original issue reported on code.google.com by thakis@chromium.org on 17 Nov 2011 at 12:03

[GoogleCodeExporter]

Original comment by thakis@chromium.org on 17 Nov 2011 at 12:03

[GoogleCodeExporter]

Original comment by sergeyu@google.com on 1 Dec 2011 at 2:02

• Changed state: Started

[GoogleCodeExporter]

Refile in webrtc issue tracker if work still needs to be done here.

Original comment by juberti@google.com on 1 Jun 2013 at 4:38

• Changed state: WontFix

[GoogleCodeExporter]

Refile in webrtc issue tracker if work still needs to be done here.

Original comment by juberti@google.com on 1 Jun 2013 at 4:39

[GoogleCodeExporter]

I can't reopen issues on the libjingle tracker. I'm almost certain this isn't 
fixed. You can turn these into compile time errors by adding 
enable_wexit_time_destructors to your gyp project.

If you want to move this to the webrtc tracker, feel free to do so, but 
WontFixing a valid bug with "please file again" seems…

Original comment by thakis@chromium.org on 1 Jun 2013 at 4:47