search

burningmantech / ranger-ims-server

Ranger Incident Management System—Server
Apache License 2.0
27 stars 7 forks source link

do bulk lookups when fetching all incident reports for event #1373

Closed srabraham closed 2 weeks ago

srabraham commented 2 weeks ago

Currently this sort of fetch does up to thousands of queries each time, which seems inefficient. I had pretty good success moving the fetchIncidents call over to bulk queries, and I'm seeing at least a 2x speedup locally with this change as well.

Related: https://github.com/burningmantech/ranger-ims-server/issues/1324

github-actions[bot] commented 2 weeks ago

⚠️ Optional matrix job Py:3.14.0-alpha.1 - ubuntu-latest failed ⚠️

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.23%. Comparing base (8ab7088) to head (800fb4c). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1373 +/- ## ========================================== + Coverage 69.20% 69.23% +0.02% ========================================== Files 181 181 Lines 8901 8916 +15 Branches 1488 1490 +2 ========================================== + Hits 6160 6173 +13 - Misses 2641 2643 +2 Partials 100 100 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.