search

burningmantech / ranger-ims-server

Ranger Incident Management System—Server
Apache License 2.0
27 stars 7 forks source link

tweak login page's title and email label #1380

Closed srabraham closed 2 weeks ago

srabraham commented 2 weeks ago

I went with "email (or handle)" for a while, but I'm now thinking we should just stay simple and ask for email only.

The title of the page was a bit weird before, just saying "Log In". I think it's better to say the name of the system instead, but I could be convinced otherwise.

Before:

image

After:

image
github-actions[bot] commented 2 weeks ago

⚠️ Optional matrix job Py:3.14.0-alpha.1 - ubuntu-latest failed ⚠️

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.25%. Comparing base (aaab0ff) to head (369cd49). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ims/element/login/_login.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1380 +/- ## ========================================== + Coverage 69.23% 69.25% +0.02% ========================================== Files 181 181 Lines 8916 8916 Branches 1490 1490 ========================================== + Hits 6173 6175 +2 + Misses 2643 2642 -1 + Partials 100 99 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikeburg commented 2 weeks ago

+1 to only mentioning using an email address, and not handles. Each event, the Tech On Call team receives numerous support requests because people attempt to use their callsigns, only to discover that the callsign must be entered precisely, with exact capitalization and punctuation.

Obviously, such strict requirements are not playa brain friendly.

srabraham commented 2 weeks ago

+1 to only mentioning using an email address, and not handles. Each event, the Tech On Call team receives numerous support requests because people attempt to use their callsigns, only to discover that the callsign must be entered precisely, with exact capitalization and punctuation.

Obviously, such strict requirements are not playa brain friendly.

Yuuuup, not even while on call, I coincidentally had to help multiple people with that same thing at BRC 2024