burningmantech / ranger-ims-server

Ranger Incident Management System—Server
Apache License 2.0
27 stars 7 forks source link

api: attach incident reports when creating incident #1416

Closed srabraham closed 3 days ago

srabraham commented 3 days ago

Previously the call to create an incident report ignored any incident report numbers that were set in the request.

I want to have this in order to address Porcupine's request here https://github.com/burningmantech/ranger-ims-server/issues/372#issuecomment-1519171659

github-actions[bot] commented 3 days ago

⚠️ Optional matrix job Py:3.14.0-alpha.1 - ubuntu-latest failed ⚠️

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (14f2c8c) to head (5671456). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/ims/store/_db.py 0.00% 3 Missing and 1 partial :warning:
src/ims/application/_api.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1416 +/- ## ========================================== - Coverage 69.19% 69.13% -0.07% ========================================== Files 181 181 Lines 8926 8931 +5 Branches 1492 1494 +2 ========================================== - Hits 6176 6174 -2 - Misses 2651 2656 +5 - Partials 99 101 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

srabraham commented 3 days ago

disregard, there's an easier way to do this