search

burnt0rice / zen-themes

Zen Browser Themes to Enhance Your Browsing Experience
6 stars 0 forks source link

It covers the Audiotab icon plus's icon and also there's no hover feedback on the button #1

Closed ProbablyM-S closed 2 months ago

ProbablyM-S commented 3 months ago

video showing the issue https://github.com/user-attachments/assets/6e2b02e6-7619-4e63-bf20-db6df393286e

Great work btw! :)

KiKaraage commented 3 months ago

Personally I would suggest changes to AudioTab Icon Plus' author @DaityDay more than to this repo - so we can have options to put the audio indicator on the left side of tab icon. Audio icon on top left side and close button on the top right side would be much more ideal!

burnt0rice commented 3 months ago

Thank you for your feedback. I will add the missing hover effect.

I agree with @KiKaraage — theoretically, the close button should be on the top-right. Would it be a good compromise to add a preference to optionally move the close button to the top-left?

ProbablyM-S commented 3 months ago

Personally I would suggest changes to AudioTab Icon Plus' author @DaityDay more than to this repo - so we can have options to put the audio indicator on the left side of tab icon. Audio icon on top left side and close button on the top right side would be much more ideal!

yeah true I did think about that after opening this issue I'll actually ask the Audio Tab Icon Plus dev for it. it will definitely make more sense to have the close button on the right and I dont think adding a preference to move the close button to the left is really needed

Thank you for your feedback. I will add the missing hover effect.

I agree with @KiKaraage — theoretically, the close button should be on the top-right. Would it be a good compromise to add a preference to optionally move the close button to the top-left?

I dont think the option is really needed I should just ask the Audio Tab Icon Plus dev for it you should just add the hover effect sorry.

benstone326 commented 3 months ago

On light mode there's no BG behind the X. I would suggest a white BG. image

cprin21 commented 2 months ago

Now it just doesn't work on a.35

burnt0rice commented 2 months ago

I've implemented the hover effect and will wait until I've resolved issue #5. After that, I'll request an update for this theme.

burnt0rice commented 2 months ago

The theme has been updated and is now available in the theme store.