button-inc / service-development-toolkit

Toolkit for button applications
Apache License 2.0
5 stars 3 forks source link

497 button hero image #565

Closed joshgamache closed 2 years ago

joshgamache commented 2 years ago

Fixes #497

Proposed Changes

Learnings

I got delayed for a bit due to the test erroring (not failing). The error was something along the lines of Jest encountered an unexpected token. This was due to the module being imported into button-theme/.../HeroImage.tsx as esm rather than directly. ✔️ import { applyTheme, StyleConfig } from '@button-inc/component-library/HeroImage'; vs ❌ import { applyTheme, StyleConfig } from '@button-inc/component-library/esm/HeroImage'; Moral of the story: don't be like me, double check your auto-imports!