search

buttondown / roadmap

Buttondown's public roadmap
51 stars 0 forks source link

extra non-functional ugly scrollbars on Windows #1193

Open james-baker opened 1 year ago

james-baker commented 1 year ago

image

Expected A: slim scrollbar if this column must have a horizontal scrollbar Expected B: column somehow takes some more width for itself when there's room Expected C: ugly scrollbars, but only when they're needed/functional

Actual: In my situation, every row has a scrollbar in the Tags column, which bumps the row-height on lines that have any tags (creating uneven line heights in the table), and none of them actually scroll anything.

The picture shows the maximum # of tags I have on any subscriber - those three. Maybe they just barely fill the column? I don't know if I'm some weird edge case here.

CSS note: there seems to be an "x-overflow-scroll" explicitly set on these.

jmduke commented 1 year ago

I'm having trouble repro-ing this one — what browser/OS are ya on?

james-baker commented 1 year ago

Windows 10, Chrome 110.0.5481.178

Inspecting: image

jmduke commented 1 year ago

Ack; I suspect this is a difference between Windows and Mac on rendering the scrollbar even if its disabled/no-op

james-baker commented 11 months ago

Might want to revisit this triage decision? Looks even worse after the addition of metadata columns: image

I imagine you have a fair number of Windows users, and I believe you just want "overflow: auto" instead of "overflow: scroll" https://kilianvalkhof.com/2021/css-html/you-want-overflow-auto-not-overflow-scroll/

jmduke commented 11 months ago

:eyes: Will take a look!

james-baker commented 7 months ago

Bumping this one, only because I think it's such a high value-to-effort ratio. Really ugly, (hopefully) really easy fix!

james-baker commented 6 months ago

I see that the inside-the-table horizontal scrollbars have been fixed on Windows, yay. The current fix lets the right side of the table get cut off by insufficient window size, no pane-level horizontal scrollbar appears, boo. Also, I'll note that the left sidebar GAINED a persistent non-functional scrollbar with the settings-pages update, so there are still 3 permanent ugly vertical scrollbars (2 on the right edge of the window, stacked right next to each other) that make Windows feel second-class today.

jmduke commented 6 months ago

Ew, gross (and missed your bump in Jan.) Do you mind sharing a screenshot?

james-baker commented 5 months ago

Screenshot today image

global search-and-replace elimination of overflow:scroll ??

jmduke commented 5 months ago

@james-baker oh god (though at least the cell row ones are gone now!?). Can you confirm you still see the triple-nesting on, say, tags?

james-baker commented 5 months ago

Yes it's triple -nested on all of the main pages

On Thu, Apr 18, 2024, 12:33 PM Justin Duke @.***> wrote:

@james-baker https://github.com/james-baker oh god (though at least the cell row ones are gone now!?). Can you confirm you still see the triple-nesting on, say, tags?

— Reply to this email directly, view it on GitHub https://github.com/buttondown/roadmap/issues/1193#issuecomment-2065074263, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAV4DYK7KYX64OFTK7QCS3Y6ANWVAVCNFSM6AAAAAAVHKJEIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRVGA3TIMRWGM . You are receiving this because you were mentioned.Message ID: @.***>

james-baker commented 1 month ago

New editor experience: image