buttonwoodcx / bcx-aurelia-reorderable-repeat

An Aurelia repeater supports drag & drop reordering automatically.
https://buttonwoodcx.github.io/doc-bcx-aurelia-dnd/reorderable-repeat
MIT License
19 stars 5 forks source link

Buggy behaviour when pressing escape #19

Closed HeyndrickxKarel closed 4 years ago

HeyndrickxKarel commented 4 years ago

Hi

So I noticed an issue in the example Multiple lists with reorderable-group-for on your documentation.

To try these out in dumber gist you set up, you need to first click in preview window in order for the escape event to register.

image

HeyndrickxKarel commented 4 years ago

Nevermind, problem was just solved by clearing my cache. I suppose you have already fixed this :)

3cp commented 4 years ago

Dumber gist is bit troublesome for capturing esc. The embedded app window runs in an iframe, that's why you have to click it first (browser focus I guess).

The dnd doc site needs to be updated for the esc cancel feature. I have not done that. https://github.com/buttonwoodcx/doc-bcx-aurelia-dnd/issues/2

3cp commented 4 years ago

There are few more examples in the doc needs to be updated to handle cancellation too.