search

buttonwoodcx / bcx-aurelia-reorderable-repeat

An Aurelia repeater supports drag & drop reordering automatically.
https://buttonwoodcx.github.io/doc-bcx-aurelia-dnd/reorderable-repeat
MIT License
19 stars 5 forks source link

Slowdown on long list having nested components #8

Closed lars1 closed 5 years ago

lars1 commented 5 years ago

The company I work for have been very happy using reorderable-repeat in production, but recently we have hit a problem when a list contains several hundred items.

The list's rows are custom elements which consist of sub-elements, sub-sub-elements and so on.

I've created a demo project that reproduces the problem.

3cp commented 5 years ago

Thanks! Unfortunately that is expected, it’s documented in limitations in doc.

The inefficient rendering strategy is to support reordering array of primitive values. Since most users only reorder handful items, I never bothered to improve it.

With your demo, I can try to fix it with original repeat rendering optimization for array of objects (which is the use case for most users). I will get it done in few days.

3cp commented 5 years ago

Well, easier than I thought. Thanks for the push on lazy me. Will release soon.

3cp commented 5 years ago

v1.2.1 is released.

lars1 commented 5 years ago

Thank you very much for the fix, and the quick delivery! :smile: I have updated our project and can confirm that it is working very well.