search

buzzfeed / sso

sso, aka S.S.Octopus, aka octoboi, is a single sign-on solution for securing internal services
MIT License
3.07k stars 187 forks source link

fillcache: remove group from cache if it can't be found by the identity provider #282

Closed Jusshersmith closed 4 years ago

Jusshersmith commented 4 years ago

Problem

Groups aren't actively removed from the fillcache if we find that the group can't be found (based on return codes from the identity provider).

Solution

If the group can't be found by the identity provider, then delete it from the fillcache.

codecov[bot] commented 4 years ago

Codecov Report

Merging #282 into master will increase coverage by 0.01%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   62.51%   62.53%   +0.01%     
==========================================
  Files          54       54              
  Lines        4199     4201       +2     
==========================================
+ Hits         2625     2627       +2     
  Misses       1385     1385              
  Partials      189      189
Impacted Files Coverage Δ
internal/auth/providers/google_admin.go 0% <0%> (ø) :arrow_up:
internal/pkg/groups/fillcache.go 74.64% <100%> (+0.73%) :arrow_up: