bvschaik / julius

An open source re-implementation of Caesar III
GNU Affero General Public License v3.0
2.79k stars 312 forks source link

Fix bug where sheep could get an out of bounds destination. #662

Closed PrettyFlower closed 1 year ago

PrettyFlower commented 1 year ago

To reproduce, load up Tarraco from campaign (attached), and add a conditional breakpoint here: image

After a short wait this should get hit, and will result in an out of bounds memory check on the next line. What's happening here is:

I've gone ahead and fixed the issue for all the animal herds. It wasn't clear to me if this was an issue for soldier and enemy formations as well, but we should probably check that.

Architect1.zip

crudelios commented 1 year ago

This is falling the earthquake tests for some reason. We'll need to check if there's a legitimate reason for that or if we should add an exception to the test.