search

bwegh / erwa

Please use https://github.com/CargoTube/cargotube or https://github.com/CargoTube/ct_erwa_api instead.
MIT License
57 stars 16 forks source link

Refactored and optimised realms #18

Closed comtihon closed 9 years ago

comtihon commented 9 years ago

Made some refactoring in big modules, moved tests to tests/eunit, move modules to directories (logically) and split realms to module with gen_server and module with interface for other processes (for better understanging code). As for optimisation - I made realms ets protected and made reading to in in case of get_routing and get_middleware_list from calling processes to optimise speed in case of lots of processes. erwa_realms server only writes to in when adding or removing realm.

comtihon commented 9 years ago

I broke tests with refactoring somehow. Will reopen, when ready.

bwegh commented 9 years ago

it is great to have someone else look through the code, thanks for your help!

comtihon commented 9 years ago

Fixed all unit tests, ct not working completely, but same in master. Please see this merge, as realms changes are important. I'll continue checking project. It will be very good, if you connect with me via e-mail (my adress is in github profile) as we want to use your project and I have some arch-related questions.

bwegh commented 9 years ago

I will have a closer look into all of these changes at the weekend, that is too much for just one evening. The test are always all passing on travis, so they should stay that way (without just removing all failing ones ;) )

bwegh commented 9 years ago

thanks for your help, did some cherry picking on your code :-)