search

bwlewis / rredis

R client for Redis
http://illposed.net/
93 stars 25 forks source link

`redisConnect` errors out when integer port is used. #16

Closed s-u closed 10 years ago

s-u commented 10 years ago

redisConnect refuses to use integer ports (e.g. redisConnect("localhost", 6379L) will throw an error). The culprit is

stopifnot(class(port) == "numeric")

which should read

stopifnot(is.numeric(port))

(integers are numeric, but they have the class "integer").

bwlewis commented 10 years ago

Thanks, should be fixed in commit

https://github.com/bwlewis/rredis/commit/98bdaad912196ac17bc42cf89cf51ac93d76c2cc

along with a few similar type checking cases.