search

bxparks / AceButton

An adjustable, compact, event-driven button library for Arduino that debounces and dispatches events to a user-defined event handler.
MIT License
385 stars 37 forks source link

Update README.md #30

Closed salvagione closed 5 years ago

salvagione commented 5 years ago

Correcting typos.

bxparks commented 5 years ago

Hi, thanks for the PR. I'm traveling. I Will take a look when I get back.

On Sun, Sep 15, 2019, 12:31 Paolo Salvagione notifications@github.com wrote:

Correcting typos.

You can view, comment on, or merge this pull request online at:

https://github.com/bxparks/AceButton/pull/30 Commit Summary

  • Update README.md

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bxparks/AceButton/pull/30?email_source=notifications&email_token=AGNPQIQ6I2E3JI6RB6JK53LQJZ5QHA5CNFSM4IW3Q732YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLOK6DQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AGNPQIVBHL42PZ6MAI44QRTQJZ5QHANCNFSM4IW3Q73Q .

salvagione commented 5 years ago

Nothing earth shattering just a few typos I caught while trying to grok AUnit and TDD. Thank you for publishing your work, you clearly know what you're doing.

bxparks commented 5 years ago

Back from vacation! Thanks for the corrections. AceButton was the first project where I used AUnit. I think my style and techniques have evolved since then. Take a look at the unit tests for AceTime. I think those are better examples of unit and integration tests.

bxparks commented 5 years ago

Another side comment (in case my opinion matters :-)): I'm not a fan of TDD. I believe that code should always be tested (using both unit and integration tests). But I do not believe that tests should be written first, then used to drive the development process.

salvagione commented 5 years ago

Your opinion matters, if only because you’ve walked the path before me.

If not full TDD, what’s your favorite method?

I have James’ book and I’ve finally got the CppUtest tool chain up and working. I’m enjoying the TDD methodology so far, especially as I often don’t have the target hardware right away.

There’s something magical about writing code using just the sensor spec sheets and compiling off target.

We’ll see if the magic vanishes when the target arrives. Even so, I can’t imagine it being as bad as it has on the past.

If so let me know.

Best, Paolo

On Mon, Sep 30, 2019 at 9:14 PM Brian Park notifications@github.com wrote:

Another side comment (in case my opinion matters :-)): I'm not a fan of TDD. I believe that code should always be tested (using both unit and integration tests). But I do not believe that tests should be written first, then used to drive the development process.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bxparks/AceButton/pull/30?email_source=notifications&email_token=AB4NHHLZYX6YKJBLECID52LQMLFBXA5CNFSM4IW3Q732YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD774BRY#issuecomment-536854727, or mute the thread https://github.com/notifications/unsubscribe-auth/AB4NHHILVIGDCKV4V4DPWXDQMLFBXANCNFSM4IW3Q73Q .