search

bxshi / ProjE

Embedding Projection for Knowledge Graph Completion
MIT License
76 stars 41 forks source link

Why yield test_triple in validation_data method? #1

Closed ZichaoHuang closed 7 years ago

ZichaoHuang commented 7 years ago

I think the validation_data method should yields self.__valid_triple, but in ProjE_softmax.py it yields self.__test_triple, why?

bxshi commented 7 years ago

Good catch! I think that is a mistake... Thanks for pointing it out! Feel free to make a PR our I'll correct it later :)