search

byte-physics / igortest

Igor Pro Universal Testing Framework
https://docs.byte-physics.de/igor-unit-testing-framework/
BSD 3-Clause "New" or "Revised" License
7 stars 2 forks source link

*_EQUAL_STR and *_NEQ_STR are now pass-by-value #411

Closed Garados007 closed 1 year ago

Garados007 commented 1 year ago

The string paramater for WARN_EQUAL_STR, CHECK_EQUAL_STR, REQUIRE_EQUAL_STR, WARN_NEQ_STR, CHECK_NEQ_STR and REQUIRE_NEQ_STR are now pass-by-value. This allows simpler usage and unify the api for the EQUAL and NEQ variants.

These assertions were originally designed to be pass-by-reference to catch the edge-case when the user provide a null string. There is no longer a need take this in account as there are _NULL_STR and _PROPER_STR assertions that are designed to check for these edge cases.

Close #363

Garados007 commented 1 year ago

@t-b @MichaelHuth Ready for Review.