search

bytecodealliance / componentize-py

Apache License 2.0
158 stars 19 forks source link

fix artifact naming in release #114

Closed benbrandt closed 1 month ago

benbrandt commented 1 month ago

@dicej Based on my own python release CI in the text-splitter crate/package, I think this should solve it... but we won't really know until it is on main...

The issue is that in the new version you have to have unique names and then merge them in the download pattern, as far as I understand: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

dicej commented 1 month ago

Thanks for trying; looks like we've still got an issue: https://github.com/bytecodealliance/componentize-py/actions/runs/11507239372/job/32033830809

BTW, I think you should be able to enable Actions on your fork and test this kind of thing by pushing to your main branch. That's what I've done in the past with other projects.

benbrandt commented 1 month ago

Thanks for the hint. Resolved here: https://github.com/bytecodealliance/componentize-py/pull/116