search

bytecodealliance / lucet

Lucet, the Sandboxing WebAssembly Compiler.
Apache License 2.0
4.06k stars 164 forks source link

Compiling on linux: MD; fix typo for linking #600

Closed Horki closed 3 years ago

Horki commented 3 years ago

Fix 'typo' linking path for "wasi sysroot"

sudo ln -s /opt/wasi-sdk-*/share/wasi-sysroot /opt/wasi-sysroot => sudo ln -s /opt/wasi-sdk-11.0/share/wasi-sysroot /opt/wasi-sysroot

jedisct1 commented 3 years ago

Hi!

This is not a typo :)

* is replaced by the shell with any file matching the pattern.

Using this in the documentation instead of hardcoding a specific version helps the instructions stay relevant even as new versions of the SDK are released.

jedisct1 commented 3 years ago

Just noticed that the previous lines hardcode version numbers. Since the whole paragraph would need to be updated on a new release anyway, we can indeed hardcode that one as well.

A better alternative would be to retrieve the latest version using the /latest API as done by most update scripts. But that can be done later.

Thanks!

Horki commented 3 years ago

@jedisct1 when I use '' with GNU ln (v8.32), I receive an error ` no matches found: /opt/wasi-sdk-/share/wasi-sysroot`

pchickey commented 3 years ago

Thanks for this fix. The CI failures are due to cargo audit and have been fixed upstream - can you please rebase on or merge with main?

Horki commented 3 years ago

@pchickey rebased and pushed

Horki commented 3 years ago

@pchickey fixed

pchickey commented 3 years ago

Thanks!