bytedeco / javacpp-presets

The missing Java distribution of native C++ libraries
Other
2.68k stars 744 forks source link

Fix mapping of unique pointers #1462

Closed HGuillemet closed 10 months ago

HGuillemet commented 10 months ago

When a native function takes a unique_ptr to some class as an argument AND if that class can be instantiated from Java, the Java constructors must by annotated with @UniquePtr and @Name.

Affected presets: Pytorch and Tensorflow-lite.

HGuillemet commented 10 months ago

I'm done for the presets. I'm going to push another small fix for javacpp

saudet commented 10 months ago

Any estimates on when that fix is going to land?

HGuillemet commented 10 months ago

Regression tests on presets are currently running. I'll check the result in ~ 8 hours.