search

byteface / domonic

Create HTML with python 3 using a standard DOM API. Includes a python port of JavaScript for interoperability and tons of other cool features. A fast prototyping library.
https://domonic.readthedocs.io/
MIT License
129 stars 13 forks source link

Some tests are skipped due to duplicate names #57

Closed code-review-doctor closed 2 years ago

code-review-doctor commented 2 years ago

Test names must be unique per scope otherwise the second test overrides the first one with the same name.

For example if you had a test file that does:

def test_a():
    pass

def test_a():
    pass

Then only the second test_a will be ran. More details here.

These are the tests that are overriding previously defined tests due to this problem:

https://github.com/byteface/domonic/blob/fee5704ab051d40c7b3fec5488a44d3ab1ee027c/tests/test_dom.py#L1012

I found this issue automatically, see other issues here