byteyilabs / yi-note

YiNote browser extension - online video note taking tool
https://www.yinote.co
GNU General Public License v3.0
356 stars 50 forks source link

Markdown Export Creating HTML Files, Not Markdown #84

Closed golflabel closed 3 years ago

golflabel commented 3 years ago

Bug description "Export Markdown" option exports HTML instead of Markdown.

To Reproduce Steps to reproduce the behavior:

  1. Click "Export Markdown" option.

Expected behavior A properly Markdown-formatted file would be saved.

Screenshots After taking notes on any given video in YiNote, I click here:

ScreenShot 2021-02-08 at 12 31 55@2x

Then my .md file looks like this:

ScreenShot 2021-02-08 at 12 34 02@2x

The css styling and clickable links contained in the source text are now missing when rendering a Markdown preview:

ScreenShot 2021-02-08 at 12 35 12@2x

Browser

Additional context

sebastian-muthwill commented 3 years ago

It seems that in version v1.6.0 in the Chrome extension the behavior is slightly different. Here the exported markdown file doesn´t contain the <p> tags but still has commented out the time stamp links.

current behavior


<!-- # [5 steps to study with Obsidian and how I use it for exam revision using NeuraCache and Anki](https://www.youtube.com/watch?v=Bf3d7qyz17c) -->

<!-- ## [4:57](https://www.youtube.com/watch?v=Bf3d7qyz17c&t=297) -->

Notizen als Bulletpoints erstellen und mit Screenshots und weiteren Daten anreichern.

this causes markdown preview to threat this as a comment, and it will not be shown.

proposed solution

removing the comment part <!-- -->from the markdown export