Hi,
I came across your codebase while searching for an implementation of the foot skating metric, and I want to express my gratitude for sharing such a clean codebase. However, I noticed a problem that I believe needs attention.
If I understand correctly, the issue is mainly cuased by this line of the code. It makes a binary tensor of shape BxTx4 (where B is the batch size and T is the sequence length) for the foot joints in the order of [0,2,1,3] i.e., L_Ankle, L_Foot, R_Ankle, R_Foot. However, a few lines later here, it is multiplied by v and h tensors that represent the speed and height of each joint in the order of [0,1,2,3] i.e., L_Ankle, R_Ankle, L_Foot, R_Foot. This mis-alignment in the tensor dimensions can potentially make the resulting score invalid.
Hi, I came across your codebase while searching for an implementation of the foot skating metric, and I want to express my gratitude for sharing such a clean codebase. However, I noticed a problem that I believe needs attention.
If I understand correctly, the issue is mainly cuased by this line of the code. It makes a binary tensor of shape
BxTx4(whereBis the batch size andTis the sequence length) for the foot joints in the order of [0,2,1,3] i.e., L_Ankle, L_Foot, R_Ankle, R_Foot. However, a few lines later here, it is multiplied byvandhtensors that represent the speed and height of each joint in the order of [0,1,2,3] i.e., L_Ankle, R_Ankle, L_Foot, R_Foot. This mis-alignment in the tensor dimensions can potentially make the resulting score invalid.Please let me know if I am missing something.