search

c-martinez / shellther

shell link to etherpad
8 stars 5 forks source link

shelllogger available via PyPI #5

Open wking opened 8 years ago

wking commented 8 years ago

This package bundles shelllogger, but that package seems to be available via PyPI, with a defunct Google Code site linking a current GitHub site. I'm not sure what the license on this project is, but shelllogger seems to be GPLv3.

c-martinez commented 8 years ago

Shelllogger bundled here comes from a different source than the one available via PyPI. This version does not mention a GPLv3. Still, it might be better to avoid bundling it. Also, @mkuzak suggested to use Apache2, if possible.

Installing via PyPI, you do not get access to the sanitize function (the one bit we are using in shellther), which is a bit unfortunate. Not sure if we could just use shelllogger instead of script -- will look into it.

I can see two alternatives to avoid bundling:

alexsavio commented 8 years ago

All the sources, even the one referenced by @c-martinez leads to the same GPLv3-licensed code based and the same authors. Maybe PyDoc is ignoring the LICENSE.txt file? Anyway, are we using ONLY the sanitize function from shelllogger?? It is not too much code to have it as a dependency. I would have an own version of the sanitize function.

wking commented 8 years ago

On Tue, Mar 15, 2016 at 12:42:03AM -0700, c-martinez wrote:

Installing via PyPI, you do not get access to the sanitize function…

I haven't looked to see what ‘sanitize’ does, but you may be able to use ansi2html instead [1,2]. That package's core mission is ANSI → HTML conversion, so I imagine their PyPI-packaged version doesn't leave it out ;).

c-martinez commented 8 years ago

The sanitize function removes funky characters (not only colours, but also backspaces and such) from the output generated by the script command. I think it is similar to what is done here (another tool mentioned on the SWC mailing list). Not sure if ansi2html does the same trick, but will certainly look into it.