c-wenlong / pe

0 stars 0 forks source link

Name field is case sensitive #11

Open c-wenlong opened 4 months ago

c-wenlong commented 4 months ago

Description

Screenshot 2024-04-19 at 17.06.35.png

When it comes to names, there should be some case insensitivity. Alex Yeoh and Alex yeoh should be the same person.

Fix

You can consider case insensitivity when parsing the names, i.e. convert everything to lower or upper case when verifying if it exists.

nus-pe-bot commented 4 months ago

Team's Response

  1. Making Phone Number and Email Address Unique

The current FriendFolio system uses a contact’s name as a unique identifier. We are planning to enhance this by switching to using contact’s phone number and email as unique identifiers. This change will prevent multiple individuals from sharing the same email or phone number within the system, while allowing the existence of multiple individuals with the same name.

According to our planned enhancements, we plan to change the unique identifier from name to phone number and email. Making this change will make this a non-issue because we will allow duplicate names (because in real life you can know 2 different people with the exact same name).

In addition, in our UG, we did mention that names are case-sensitive.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]