c0c0n3 / kitt4sme.live

On a mission to bring AI to the shop floor: https://kitt4sme.eu/
MIT License
1 stars 27 forks source link

Get the update info from orion in the SADS online #336

Closed souayb closed 8 months ago

souayb commented 11 months ago

Describe the bug

The current status of SADS online update on the fixe time interval, which does not necessarily coincide with update in the context broker.

To Reproduce

Steps to reproduce the behavior:

Expected behavior

The SADS online solution is updated using the update info from the orion.

Additional context

Add any other context about the problem here.

c0c0n3 commented 11 months ago

@souayb you should change this line

to use the from_timepoint parameter instead:

karikolehmainen commented 9 months ago

What is the status of this issue and can we close it as not relevant?

c0c0n3 commented 9 months ago

@karikolehmainen @souayb this is still an issue I think, but it only affects the "online" (i.e. streaming) implementation. Since we decided the blessed implementation we'll adopt going forward until the end of the project is the "offline" (i.e. batch, see #368) one, we don't need to fix this issue. But we can leave it open as a reminder if @souayb decides to fix it in the future.

karikolehmainen commented 9 months ago

I propose to close it and reopen if necessary

            Kari Kolehmainen
            VTT
            tel.+358 40 533 0649

From: c0c0n3 @.> Sent: 18 October 2023 10:05 To: c0c0n3/kitt4sme.live @.> Cc: Kolehmainen Kari @.>; Mention @.> Subject: Re: [c0c0n3/kitt4sme.live] Get the update info from orion in the SADS online (Issue #336)

@karikolehmainenhttps://github.com/karikolehmainen @souaybhttps://github.com/souayb this is still an issue I think, but it only affects the "online" (i.e. streaming) implementation. Since we decided the blessed implementation we'll adopt going forward until the end of the project is the "offline" (i.e. batch, see #368https://github.com/c0c0n3/kitt4sme.live/pull/368) one, we don't need to fix this issue. But we can leave it open as a reminder if @souaybhttps://github.com/souayb decides to fix it in the future.

— Reply to this email directly, view it on GitHubhttps://github.com/c0c0n3/kitt4sme.live/issues/336#issuecomment-1767802191, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATJXM3UBORMUQTMKEVSODSDX755S5AVCNFSM6AAAAAA26FNNASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXHAYDEMJZGE. You are receiving this because you were mentioned.Message ID: @.***>