cBioPortal / icebox

very low priority issues
0 stars 0 forks source link

GENIE BPC post release bugs list #188

Open inodb opened 4 years ago

inodb commented 4 years ago

https://genie-private.cbioportal.org/study/summary?id=nsclc_genie_bpc

Study view fixes:

Timeline data questions:

Timeline fixes here: https://github.com/cBioPortal/cbioportal/issues/7066

alisman commented 4 years ago

@inodb samples are ordered like so: // sort samples based on event, clinical data and id // 1. based on sample collection data (timeline event) // 2. if all cases have derived normalized case types, put primary first // 3. natural sort of sample ids

I believe this means that if a primary was collected after a metast, it would still be (1)

My thought is that samples should always be ordered sequentially in the TOP track. It would be confusing if they are out of order there. I think this is same as saying, always order by collection date. That seems intuitive to me. The sequencing date seems secondary. If you were surprised to find out that a sample was collected long before it was sequenced, that would be a big deal. But if you found out that it was sequenced long after it was collected, it wouldn't be that big a deal (right?)

inodb commented 4 years ago

@alisman sorry i just moved that bit to the timeline prissmm enhancements epic. But agree order sequentially by top track makes sense. So yes order by collection date first

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.