ca-archived / iOS-NBUImagePicker

Modular image picker with Simulator-compatible AVFondation camera, assets library, filters and more.
http://cyberagent.github.io/iOS-NBUImagePicker
Apache License 2.0
193 stars 48 forks source link

Images count issue #19

Open ijameelkhan opened 7 years ago

ijameelkhan commented 7 years ago

Review the following code , in the picker class , gives me 3 images if i select 6 in the block as you increasing the index twice in the loop

This is my code where i am having an issue id callback = ^(NSArray * images){

};

// Prepare result NSMutableArray result = _mediaInfos; if (!_returnMediaInfoMode) { result = [NSMutableArray arrayWithCapacity:_mediaInfos.count]; for (NSUInteger index = 0; index < _mediaInfos.count; index++) { [result addObject:((NBUMediaInfo )_mediaInfos[index++]).editedImage]; } }

rivera-ernesto commented 7 years ago

Right. Could make a PR?

ijameelkhan commented 7 years ago

it skips half of the selected images if i select 4 i get only 2 in callback and so on

ijameelkhan commented 7 years ago

i forked the repo and fixed this problem but seems likely some issue in 1.60 'MotionOrientation_PTEz/MotionOrientation.h' file not found

rivera-ernesto commented 7 years ago

Was your branch created from the latest master?

ijameelkhan commented 7 years ago

Yes and also please try using it in Xcode 9