Add support to read configuration from ini file

sweep-ai[bot] commented 1 year ago

PR Feedback (click)

[ ] 👍 Sweep Did Well
[ ] 👎 Sweep Needs Improvement
Description

This PR adds support to read configuration options from an ini file in the project. The ini file will be located in the same directory as the binary. The ini file will contain options for UserData and CacheDir.

Summary of Changes

Modified src/portable.h to read UserData and CacheDir paths from the ini file using GetPrivateProfileStringW.
Replaced hard-coded paths in GetUserDataDir() and GetDiskCacheDir() functions with calls to GetPrivateProfileStringW.
Used GetModuleFileName to get the path of the executable file and appended the ini file name to it to get the full path of the ini file.
Passed the ini file path, section name ("opt"), and key names ("UserData" and "CacheDir") to GetPrivateProfileStringW.

Fixes #14.

🎉 Latest improvements to Sweep:

Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

Comment below, and Sweep can edit the entire PR
Comment on a file, Sweep will only modify the commented file
Edit the original issue to get Sweep to recreate the PR from scratch

sweep-ai[bot] commented 1 year ago

Rollback Files For Sweep

[ ] Rollback changes to src/portable.h

czyt commented 1 year ago

if the ini file does not exist,you should use origin path instead

sweep-ai[bot] commented 1 year ago

🚀 Wrote Changes

if the ini file does not exist,you should use origin path instead

Hi @czyt,

I decided to make the following changes:

File Path Proposed Changes

src/portable.h Modify src/portable.h with contents:
• In the GetUserDataDir() function, before calling GetPrivateProfileStringW(), add a check to see if the ini file exists using the PathFileExists() function. If the ini file does not exist, return the original path GetAppDir() + L"\\..\\Data".
• Similarly, in the GetDiskCacheDir() function, before calling GetPrivateProfileStringW(), add a check to see if the ini file exists using the PathFileExists() function. If the ini file does not exist, return the original path GetAppDir() + L"\\..\\Cache".

File Path	Proposed Changes
`src/portable.h`	Modify src/portable.h with contents: • In the `GetUserDataDir()` function, before calling `GetPrivateProfileStringW()`, add a check to see if the ini file exists using the `PathFileExists()` function. If the ini file does not exist, return the original path `GetAppDir() + L"\\..\\Data"`. • Similarly, in the `GetDiskCacheDir()` function, before calling `GetPrivateProfileStringW()`, add a check to see if the ini file exists using the `PathFileExists()` function. If the ini file does not exist, return the original path `GetAppDir() + L"\\..\\Cache"`.

ca-x / vivaldi_plus