search

cabarius / ToyBox

Toy Box is a cute and playful mod with 500+ cheats, tweaks and quality of life improvements for Pathfinder: WoTR. It was created in the spirit of Bag of Tricks & Cheat Menu but with a little different focus . It of a powerful and convenient way to edit the party composition, stats, search and add Feats, Features, Items, etc. to party members.
MIT License
166 stars 106 forks source link

Catch errors to prevent broken menu on console view #1082

Closed evandixon closed 7 months ago

evandixon commented 8 months ago

Fixes avoids #999, which is real annoying.

A better solution would be to update UIUtilities to select the appropriate ConsoleView transforms instead of PCView. I poked around with that a little but concluded I don't know what I'm doing. I figure this is the safest and simplest solution to just fix the map.

Tested using a laptop with a Logitech Gamepad F310 that was able to repro the issue, though I'll put it through some real testing later on a steam deck.

evandixon commented 8 months ago

I apologize for all the whitespace changes muddying the PR. I attempted to revert, but Visual Studio doesn't see any changes. LMK if you want me to take another crack at it.

xADDBx commented 8 months ago

Not directly a fix; more like a stop ToyBox from going kaboom when using a controller. I'll poke @cabarius to take a look and will probably take a look myself too. Once the review is finished, considering cabarius:main isn't the latest fork anyway, I'll integrate it into the most recent branch (or we'll finally merge #1058, whatever comes first I guess). After that, I'll probably take the chance to take care of #1015 and maybe #1081 and do a release with this addition?

xADDBx commented 7 months ago

Merged in https://github.com/xADDBx/ToyBox/pull/20; thanks for the contribution