cactus911 / momentForests

Java source code implementing moment forests from Nekipelov, Novosad, and Ryan (2021).
MIT License
2 stars 0 forks source link

Organize jar files #29

Open charliean942 opened 4 years ago

charliean942 commented 4 years ago

We need to remove redundant jar files (possibly pmUtility and related jars) while i) complying with different licenses and ii) keeping the codes being conducive to post estimation process.

If there are some parts of the codes or licenses that need to be updated accordingly, please do.

charliean942 commented 3 years ago

Here is the list of jar files along with their license information. A good comparison of these licenses can be found here: https://choosealicense.com/licenses/

< Public domain / no license > Jama-1.0.3.jar

< Apache License > commons-beanutils-1.9.3.jar commons-collections4-4.1.jar commons-io-2.6.jar

< GNU AGPL > itext-1.3.jar

< GNU LGPL > jcommon-1.0.23.jar jfreechart-1.0.19.jar jsci-core.jar

< From Stata software > sfi-api.jar

< By Stephen Ryan? > optimization.jar pmUtility.jar

cactus911 commented 3 years ago

Can you collate that with their distribution restrictions?

Stephen P. Ryan

Myron Northrop Professor of Economics

Olin Business School

Washington University in St. Louis

Campus Box 1133

One Brookings Drive

St. Louis, MO 63130

http://sites.wustl.edu/stephenpryan

ph: 314-935-8221


From: Byung Uk (Charlie) An notifications@github.com Sent: Wednesday, December 30, 2020 11:23 AM To: cactus911/momentForests momentForests@noreply.github.com Cc: Ryan, Stephen stephen.p.ryan@wustl.edu; Assign assign@noreply.github.com Subject: Re: [cactus911/momentForests] Organize jar files (#29)

Here is the list of jar files along with their license information. A good comparison of these licenses can be found here: https://choosealicense.com/licenses/

< Public domain / no license > Jama-1.0.3.jar

< Apache License > commons-beanutils-1.9.3.jar commons-collections4-4.1.jar commons-io-2.6.jar

< GNU AGPL > itext-1.3.jar

< GNU LGPL > jcommon-1.0.23.jar jfreechart-1.0.19.jar jsci-core.jar

< From Stata software > sfi-api.jar

< By Stephen Ryan? > optimization.jar pmUtility.jar

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/cactus911/momentForests/issues/29#issuecomment-752697062, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJOKU2WTHCJM4BY7M4YY53LSXNOXJANCNFSM4TJB3R4Q.

charliean942 commented 3 years ago

Sure, please check the email I sent too.

According to https://choosealicense.com/licenses/, one can use Apache License, GNU AGPL, and GNU LGPL if properly attaching license and copyright notices.

Please check whether optimization.jar and pmUtility.jar were written by you, and I need to check sfi-api.jar from Stata can be distributed.

cactus911 commented 3 years ago

You need Stata to run this, so we'll just have people use their own local copy of that rather than distribute sfi-api.jar.

Stephen P. Ryan

Myron Northrop Professor of Economics

Olin Business School

Washington University in St. Louis

Campus Box 1133

One Brookings Drive

St. Louis, MO 63130

http://sites.wustl.edu/stephenpryan

ph: 314-935-8221


From: Byung Uk (Charlie) An notifications@github.com Sent: Wednesday, December 30, 2020 11:47 AM To: cactus911/momentForests momentForests@noreply.github.com Cc: Ryan, Stephen stephen.p.ryan@wustl.edu; Assign assign@noreply.github.com Subject: Re: [cactus911/momentForests] Organize jar files (#29)

Sure, please check the email I sent too.

According to https://choosealicense.com/licenses/, one can use Apache License, GNU AGPL, and GNU LGPL if properly attaching license and copyright notices.

Please check whether optimization.jar and pmUtility.jar were written by you, and I need to check sfi-api.jar from Stata can be distributed.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/cactus911/momentForests/issues/29#issuecomment-752703977, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJOKU2SQWRJSKEZM7EZHIADSXNRTBANCNFSM4TJB3R4Q.

charliean942 commented 3 years ago

I took out the redundant jar files. The remaining jars are Jama-1.0.3.jar, itext-1.3.jar, optimization.jar, and pmUtility.jar.

Now the issue is that itext-1.3.jar and pmUtility.jar seem to be interconnected. I will disentangle them so that I can further remove itext-1.3.jar.

cactus911 commented 3 years ago

I am tied up writing the Handbook chapter until this Friday, but let's revisit next week?

Stephen P. Ryan

Myron Northrop Professor of Economics

Olin Business School

Washington University in St. Louis

Campus Box 1133

One Brookings Drive

St. Louis, MO 63130

http://sites.wustl.edu/stephenpryan

ph: 314-935-8221


From: Byung Uk (Charlie) An notifications@github.com Sent: Tuesday, January 12, 2021 1:06 AM To: cactus911/momentForests momentForests@noreply.github.com Cc: Ryan, Stephen stephen.p.ryan@wustl.edu; Assign assign@noreply.github.com Subject: Re: [cactus911/momentForests] Organize jar files (#29)

I took out the redundant jar files. The remaining jars are Jama-1.0.3.jar, itext-1.3.jar, optimization.jar, and pmUtility.jar.

Now the issue is that itext-1.3.jar and pmUtility.jar seem to be interconnected. I will disentangle them so that I can further remove itext-1.3.jar.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/cactus911/momentForests/issues/29#issuecomment-758453797, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJOKU2RQDTQJH2YT3COVF2LSZPYILANCNFSM4TJB3R4Q.

cactus911 commented 3 years ago

Also, code is not going to work without pmUtility.jar, I would think.

Stephen P. Ryan

Myron Northrop Professor of Economics

Olin Business School

Washington University in St. Louis

Campus Box 1133

One Brookings Drive

St. Louis, MO 63130

http://sites.wustl.edu/stephenpryan

ph: 314-935-8221


From: Ryan, Stephen stephen.p.ryan@wustl.edu Sent: Tuesday, January 12, 2021 1:33 PM To: cactus911/momentForests momentForests@noreply.github.com; cactus911/momentForests reply@reply.github.com Cc: Assign assign@noreply.github.com Subject: Re: [cactus911/momentForests] Organize jar files (#29)

I am tied up writing the Handbook chapter until this Friday, but let's revisit next week?

Stephen P. Ryan

Myron Northrop Professor of Economics

Olin Business School

Washington University in St. Louis

Campus Box 1133

One Brookings Drive

St. Louis, MO 63130

http://sites.wustl.edu/stephenpryan

ph: 314-935-8221


From: Byung Uk (Charlie) An notifications@github.com Sent: Tuesday, January 12, 2021 1:06 AM To: cactus911/momentForests momentForests@noreply.github.com Cc: Ryan, Stephen stephen.p.ryan@wustl.edu; Assign assign@noreply.github.com Subject: Re: [cactus911/momentForests] Organize jar files (#29)

I took out the redundant jar files. The remaining jars are Jama-1.0.3.jar, itext-1.3.jar, optimization.jar, and pmUtility.jar.

Now the issue is that itext-1.3.jar and pmUtility.jar seem to be interconnected. I will disentangle them so that I can further remove itext-1.3.jar.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/cactus911/momentForests/issues/29#issuecomment-758453797, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJOKU2RQDTQJH2YT3COVF2LSZPYILANCNFSM4TJB3R4Q.

charliean942 commented 3 years ago

Yes, let's revisit next week. Till then, I will try to disentangle itext-1.3.jar from pmUtility.jar. I agree that the code would not work without pmUtility.jar.

charliean942 commented 3 years ago

I rewrote pmUtility.jar so that it is independent of other jar files. Most issues are sorted out and resolved. Let's finalize the structure of jar files next week.

charliean942 commented 3 years ago

sfi-api.jar issue is resolved, and it is double checked with Stata.