cadence-workflow / cadence-java-samples

Other
97 stars 60 forks source link

clean up compiling warnings #61

Closed longquanzheng closed 8 months ago

longquanzheng commented 2 years ago
> Task :compileJava
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloMetric.java:33: warning: [deprecation] Buckets in com.uber.m3.tally has been deprecated
import com.uber.m3.tally.Buckets;
                        ^
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:149: warning: [unchecked] unchecked cast
        return (T) MyStruct.fromBytes(content);
                                     ^
  required: T
  found:    MyStruct
  where T is a type-variable:
    T extends Object declared in method <T>fromData(byte[],Class<T>,Type)
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloMetric.java:176: warning: [deprecation] Buckets in com.uber.m3.tally has been deprecated
  public Histogram histogram(final String name, final Buckets buckets) {
                                                      ^
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/bookingsaga/TripBookingActivities.java:23: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
   * @param name customer name
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns reservationID.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/bookingsaga/TripBookingActivities.java:29: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
   * @param name customer name
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns reservationID.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/bookingsaga/TripBookingActivities.java:35: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
   * @param name customer name
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns reservationID.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/bookingsaga/TripBookingActivities.java:41: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
   * @param name customer name
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns cancellationConfirmationID.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/bookingsaga/TripBookingActivities.java:48: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
   * @param name customer name
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns cancellationConfirmationID.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/bookingsaga/TripBookingActivities.java:55: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
   * @param name customer name
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns cancellationConfirmationID.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/calculation/Activities.java:23: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
   * @param a
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/calculation/Activities.java:24: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
   * @param b
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/calculation/Activities.java:23: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
   * @param a
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns a*b.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloLocalActivity.java:42: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:58: warning: [StringSplitter] String.split(String) has surprising behavior
      String[] ss = s.split("#");
                           ^
    (see https://errorprone.info/bugpattern/StringSplitter)
  Did you mean 'List<String> ss = Splitter.on('#').splitToList(s);'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:77: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:111: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @param values
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:112: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @return
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:113: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @throws DataConverterException
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:138: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @param content
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:139: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @param valueClass
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:140: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @param valueType
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:141: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @param <T>
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:142: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @return
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloDataConverter.java:143: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
     * @throws DataConverterException
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloSideEffect.java:46: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return set value */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns set value.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloSignal.java:50: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
     * @return list of greeting strings that were received through the waitForNameMethod. This
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns list of greeting strings that were received through the waitForNameMethod. This'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloCancellation.java:49: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloSearchAttributes.java:49: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloSearchAttributes.java:206: warning: [JavaTimeDefaultTimeZone] ZonedDateTime.now() is not allowed because it silently uses the system default time-zone. You must pass an explicit time-zone (e.g., ZoneId.of("America/Los_Angeles")) to this method.
    ZonedDateTime currentDateTime = ZonedDateTime.now();
                                                     ^
    (see https://errorprone.info/bugpattern/JavaTimeDefaultTimeZone)
  Did you mean 'ZonedDateTime currentDateTime = ZonedDateTime.now(ZoneId.systemDefault());'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloActivity.java:42: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloQuery.java:52: warning: [UnusedVariable] The field 'greeting' is never read.
    private String greeting;
                   ^
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean to remove this line?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloActivityRetry.java:45: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloSignalAndResponse.java:65: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
     * @return list of greeting strings that were received through the receiveName Method. This
       ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns list of greeting strings that were received through the receiveName Method. This'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloSignalAndResponse.java:201: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
   * @param workflowClient
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloSignalAndResponse.java:202: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
   * @param workflowId
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloSignalAndResponse.java:203: warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
   * @param runId
     ^
    (see http://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloMetric.java:125: warning: [UnusedVariable] The local variable 'httpServer' is never read.
    HTTPServer httpServer = new HTTPServer(new InetSocketAddress(9098), registry);
               ^
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean to remove this line or 'new HTTPServer(new InetSocketAddress(9098), registry);'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloMetric.java:62: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloWorkerSetup.java:44: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloChild.java:69: warning: [UnusedMethod] Private method 'demoAsyncChildRun' is never used.
    private String demoAsyncChildRun(String name) {
                   ^
    (see https://errorprone.info/bugpattern/UnusedMethod)
  Did you mean to remove this line?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloChild.java:41: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloAsyncActivityCompletion.java:46: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
/Users/qlong/indeed/cadence-java-samples/src/main/java/com/uber/cadence/samples/hello/HelloAsyncLambda.java:45: warning: [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    /** @return greeting string */
        ^
    (see http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '/** Returns greeting string.'?
43 warnings
ibarrajo commented 8 months ago

Thank you for reporting, I've verified this is no longer an issue.

Latest build logs: https://github.com/uber/cadence-java-samples/actions/runs/8195603371/job/22414163020