cadop / dhart

A library for Navigation Graphs, Visibility, Raycasting and other features for Design Humans Analysis RoboTics (DHART).
https://cadop.github.io/dhart/
GNU General Public License v3.0
13 stars 7 forks source link

Overloads for C# interface to accept floats #47

Closed cadop closed 1 year ago

cadop commented 1 year ago

port optimizations from OcclusionRays to other methods such as this one ? https://github.com/cadop/dhart/blob/26102d0f38860b8855df3670de68053aa372ae71/src/Csharp/packages/raytracer/src/RayTracerNative.cs#L249-L254

Originally posted by @mariuszhermansdorfer in https://github.com/cadop/dhart/issues/46#issuecomment-1382430379

mariuszhermansdorfer commented 1 year ago

@cadop, I added overloads to the remaining methods to accept float[] as input as well. Would you like me to push these to the dev branch as well? image

cadop commented 1 year ago

@mariuszhermansdorfer yes that would be great thank you!

cadop commented 1 year ago

Also I just realized what your comment was. I thought it was talking about OpenMP, which is what I did on the dev branch recently. Now I see what you asked!

mariuszhermansdorfer commented 1 year ago

Your initial interpretation was right - I asked to port all optimizations to other methods as well. Both the float[] input and OpenMP

mariuszhermansdorfer commented 1 year ago

Could you point me to where the OpenMP are optimizations are in the previous code so that I could try and scale it to the other methods?

cadop commented 1 year ago

I already did the update to openmp on dev