cadsondemak / kanit

Kanit is a Thai + Latin formal sans serif font family with 18 styles
https://cadsondemak.github.io/kanit
SIL Open Font License 1.1
83 stars 25 forks source link

GF update : vertical metrics #12

Closed RosaWagner closed 4 years ago

RosaWagner commented 4 years ago

I am almost done with reviewing the changes to update the font on Google Fonts, although few things doesn't match Google specs anymore. Biggest issue is the vertical metrics, I think a decision should be made before I submit to you a PR with the modifications.

Version 1.051 (Source repo) typoAscender = 750; typoDescender = "-250"; typoLineGap = 200; winAscent = 1100; winDescent = 395; use_typo_metrics = disabled

Version 1.002 (GF repo) typoAscender = 750; typoDescender = "-250"; typoLineGap = 200; winAscent = 1100; winDescent = 395; hheaAscender = 1100; hheaDescender = "-395"; use_typo_metrics = disabled

What’s wrong with it ?

What is recommended ?

Suggested vertical metrics for next update (version 2.000) 1) We give former WIN metrics to TYPO and HHEA metrics for a minimal impact on web and office applications (but existing indesign documents will be impacted, and linespacing is a bit loose). TypoAscender = HheaAscender = 1100 TypoDescender = HheaDescender = -395 TypoLineGap = HheaLineGap = 0 winAscent = 1180 (y-max rounded up) winDescent = 400 (y-min rounded up) use_typo_metrics = enabled

2) Another solution for good user experience would be these values (linespacing 125% of UPM, caps centred), although it would modify deeply existing documents on every platforms and applications: TypoAscender = HheaAscender = 946 TypoDescender = HheaDescender = -302 TypoLineGap = HheaLineGap = 0 winAscent = 1180 winDescent = 400 use_typo_metrics = enabled

@davelab6 : I used Marc script to have about 125% of linespacing and I then recalculated to center capitals (GF script suggest 975 and -242). Which solution would you recommend ?

RosaWagner commented 4 years ago

Maybe there were a lot of informations in this post. Let's rephrase this way: vertical metrics doesn't match Google Spec, the update of this font is a good opportunity to correct the vertical metrics as well :) To avoid regression we suggest solution 1) above. The important thing here is to preserve current paragraph set up on web pages using the font. Do you agree ?

suppakit- commented 4 years ago

I think it is good if it adapts to Google Spec. What we care about is people who have used previous versions. If there is no effect on the original layout.

RosaWagner commented 4 years ago

On the web pages there will be no changes.

suppakit- commented 4 years ago

OK. I agree with you. Thank you very much for the advice.