cagnulein / qdomyos-zwift

Zwift bridge for smart treadmills and bike/cyclette
https://www.qzfitness.com/
GNU General Public License v3.0
370 stars 109 forks source link

[BUG] Proform RL Rower - A 5 minutes countdown starts rower side when using QZ #1713

Closed jscti closed 9 months ago

jscti commented 11 months ago

Describe the bug When using QZ and starting a basic "rowing session", as soon as I start rowing, the "0:00" timer on the rower becomes a countdown timer starting at "5:00". QZ side, the "elapsed time" show the correct value, and I would like the same value rower side

Activated option:

To Reproduce Steps to reproduce the behavior:

Expected behavior Let rower count time normally/forward from 0:00.

Smartphone (please complete the following information):

Append a debug log debug-Wed_Oct_18_17_34_27_2023.log

Thanks :)

cagnulein commented 11 months ago

1643

cagnulein commented 11 months ago

@brupec are you still using QZ? do you see the same behaviour?

brupec commented 11 months ago

@brupec are you still using QZ? do you see the same behaviour?

Hi Roberto, sorry was quite busy this week and forgot to answer you. I'll check today

brupec commented 11 months ago

Indeed I have same behavior as mentionned by jscti

cagnulein commented 11 months ago

@brupec great, since I used your hci snoof for the implementation, can you do another hci snoof with a manual workout in order to don't have this behaviour?

brupec commented 11 months ago

I need to do it in the official app from proform right? I think I did manual training in the latest I sent you

Le mar. 24 oct. 2023, 15:00, Roberto Viola @.***> a écrit :

@brupec https://github.com/brupec great, since I used your hci snoof for the implementation, can you do another hci snoof with a manual workout in order to don't have this behaviour?

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/1713#issuecomment-1777159854, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAUS7YLG3O7EDZU72XF5WD3YA63V5AVCNFSM6AAAAAA6FX7QS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGE2TSOBVGQ . You are receiving this because you were mentioned.Message ID: @.***>

cagnulein commented 11 months ago

I need to do it in the official app from proform right?

yes

I think I did manual training in the latest I sent you

maybe didn't check about the countdown?

brupec commented 11 months ago

I need to do it in the official app from proform right?

yes

I think I did manual training in the latest I sent you

maybe didn't check about the countdown?

the problem is I did the try with the trial of the app and it's finished, I have no access anymore. maybe OP didn't do his trial and could do the HCI ?

cagnulein commented 11 months ago

@jscti can you help? @brupec maybe you can create another fake account with another email account?

jscti commented 11 months ago

Trial also ended but there is a "free manual workout" mode working without any subscription

jscti commented 11 months ago

How can I help ? I didn't follow the "hci snoof" stuff and willing to try ^^

cagnulein commented 11 months ago

@jscti this way https://github.com/cagnulein/qdomyos-zwift/blob/master/docs/20_supported_devices_and_applications.md#android-device

jscti commented 11 months ago

Ok it should be this : btsnooz_hci.log

I did (while bt spoof was active) :

cagnulein commented 11 months ago

argh @jscti unfortunately this android device seems to truncate the messages :( it happens with some chinese phones. which phone is it? do you have another one?

jscti commented 11 months ago

Oh that's a Google Pixel 6 -_- I don't have any other device :/

cagnulein commented 11 months ago

that's strange, I have a pixel 7 and it's not doing this...is the default rom?

jscti commented 11 months ago

Yeah full stock, nothing special. Is it better ? : btsnooz_hci.log

If not @brupec could you try a "Manual workout" in the ifit app ? (the button is at the bottom of the "rower" screen) :
image

brupec commented 11 months ago

Hi, sorry I went to live in Spain for some month and left rower back home... Good luck guys, if still need when I come back I'll try

Le mer. 1 nov. 2023, 18:08, jscti @.***> a écrit :

Yeah full stock, nothing special. Is it better ? : btsnooz_hci.log https://github.com/cagnulein/qdomyos-zwift/files/13229722/btsnooz_hci.log

If not @brupec https://github.com/brupec could you try a "Manual workout" in the ifit app ? (the button is at the bottom of the "rower" screen) : [image: image] https://user-images.githubusercontent.com/1594035/279746819-8a0841ed-75d1-4710-bb10-61f5508aec1f.png

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/1713#issuecomment-1789331970, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAUS7YMLDDVPXVIF4JMNJLDYCJ6X3AVCNFSM6AAAAAA6FX7QS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBZGMZTCOJXGA . You are receiving this because you were mentioned.Message ID: @.***>

cagnulein commented 10 months ago

Yeah full stock, nothing special. Is it better ?

argh unfortunately not, always only the 3 first bytes of each frame :(

don't you have another android device to test ?

stale[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jscti commented 10 months ago

Hi there.

I found a device where the frames are not truncated.

Here is the logs : btsnoop_hci.log

What I did with IFIT app :

Hope that helps

cagnulein commented 10 months ago

perfect @jscti I will create a branch for you to test this out! I will let you know when I will be ready (hopefully today!)

cagnulein commented 10 months ago

done @jscti download this https://github.com/cagnulein/qdomyos-zwift/suites/18332912934/artifacts/1060853568 and let me know if it's any better!

jscti commented 10 months ago

Hi there thanks.

Nop, still starting countdown from 5"00'. Tell me if you need anything

cagnulein commented 10 months ago

argh, thanks, i will check again the log in order to check if there are other differences

cagnulein commented 10 months ago

@jscti are you seeing the 5 min countdown as soon as qz is connected? or some seconds after?

jscti commented 10 months ago

Well, i tried many things :

Same scenario without QZ, the last step becomes :

I also got a weird behavior when I stoped the session from QZ :

Lastly (not related to my issue), the "stop" button doesn't seem to reset the data from the main screen (when we come back to the main screen after closing the session graphs). Only when clickgin "start" the data resets.

cagnulein commented 10 months ago

ok thanks, i will check again the log. Last thing: in ifit instead what do you see? i mean you start the ifit app, it connects and the time elasped how it behaves?

jscti commented 10 months ago

All my tests from today are without using IFIT app. Just basic training directly on the rower without anything except QZ

cagnulein commented 10 months ago

yeah i was meaning about the ifit session that you collect with the hci snoof. How it behaves?

jscti commented 10 months ago

Whe I recorded the HCI log the timer shown in the app and the one on the Rower were totally in sync (stopwatch from 0"00') without any second difference. QZ was not active during the HCI log

cagnulein commented 10 months ago

ok, that's strange, should be same now. Ok thanks for the details, I will check the log again

cagnulein commented 10 months ago

interesting, note for me: i found a Value: fe022003 packet that could be a start packet did you press a start button in the ifit app when you collect the hci snoof? I guess so (this packet is after 20 seconds from the connection with the rower)

Roberto Viola Software engineer and open source enthusiast http://robertoviola.cloud

Il giorno mar 21 nov 2023 alle ore 16:28 jscti @.***> ha scritto:

Whe I recorded the HCI log the timer shown in the app and the one on the Rower were totally in sync (stopwatch from 0"00') without any second difference. QZ was not active during the HCI log

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/1713#issuecomment-1821146850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWG35ERZUKMX3EF2P2LYFTCCJAVCNFSM6AAAAAA6FX7QS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGE2DMOBVGA . You are receiving this because you were assigned.Message ID: @.***>

jscti commented 10 months ago

During the collect, I started a workout where the IFIT app control the rower so I think the app itself may have send a "forced start" once I started the training from the app (without even rowing myself yet) yeah

cagnulein commented 10 months ago

confirmed, it's the start. let me try to implement this! i will send the start when you connect to qz, do you agree? or do you want to add it to the start button of qz?

jscti commented 10 months ago

Well I don't know at all.

Things to consider :

But this "start thing" only fixes the second "weird behevior" found today here https://github.com/cagnulein/qdomyos-zwift/issues/1713#issuecomment-1821108822 ? The 5minute countdown is not related ?

cagnulein commented 10 months ago

this start thing should fix the 5 minute countdown. i'm doing it right now, i will put it in the connection phase

cagnulein commented 10 months ago

it's building https://github.com/cagnulein/qdomyos-zwift/actions/runs/6946442999 Let me know when you will try!

jscti commented 10 months ago

Well I'm lost ^^

Tried a lot of things, and got totally different results each time. At first: same bug, countdown starts from 5'00" Then tried /stop/play/pause from app : Still a countdown but this time from 4"00' Then bug not reproducted and timer starts at 0"00' yipiii Until rower is totally blocked (no response when rowing).

It's like the "start packet" is more like a "lock packet". Before QZ never did "start" the timer/countdown of the rower.

Rower side, the "start" only trigger when I start rowing or does not trigger at all when QS is active (and bugged)

Seems really complicated to debug to me :/

cagnulein commented 10 months ago

if you agree i will continue the analysis tomorrow. unfortunately only you can test this, i can only see the log :)

Il giorno mar 21 nov 2023 alle 17:49 jscti @.***> ha scritto:

Well I'm lost ^^

Tried a lot of things, and got totally different results each time. At first: same bug, countdown starts from 5'00" Then tried /stop/play/pause from app : Still a countdown but this time from 4"00' Then bug not reproducted and timer starts at 0"00' yipiii Until rower is totally blocked (no response when rowing).

It's like the "start packet" is more like a "lock packet". Before QZ never did "start" the timer/countdown of the rower.

Rower side, the "start" only trigger when I start rowing or does not trigger at all when QS is active (and bugged)

Seems really complicated to debug to me :/

— Reply to this email directly, view it on GitHub https://github.com/cagnulein/qdomyos-zwift/issues/1713#issuecomment-1821292583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALYWCCU76NERQDF77PDITYFTLRLAVCNFSM6AAAAAA6FX7QS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGI4TENJYGM . You are receiving this because you were assigned.Message ID: @.***>

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.