search

cagpie / node-canvas-with-twemoji

Draw text with Twemoji on node-canvas
MIT License
33 stars 12 forks source link

fix: unlock node-canvas version: #23

Open ArmorDarks opened 1 year ago

ArmorDarks commented 1 year ago

Otherwise, it will force NPM to install an additional version if it doesn't match a version of the project.

Because of an internal incompatibility between some node-canvas versions, this will result in TypeError when image loaded by v2.6.1 will be used in 2d context from v2.9.1

cagpie commented 1 year ago

Thanks for the pull request.

Since canvas version 2.7.0 or higher has a rendering problem, it is fixed at version 2.6.1. https://github.com/cagpie/node-canvas-with-twemoji/issues/8

I was waiting for the canvas problem to be resolved, but considering the support of the node version, it may be better to think of another means.

ArmorDarks commented 1 year ago

@cagpie I understand the reasoning behind the lock.

So far it's a choice between having some discrepancies with node-canvas 2.7.0+, or lib not working at all because internally it uses node-canvas which is incompatible with node-canvas 2.8.0+ (maybe with 2.7.0 too, didn't test with it). Or you happen to have a better option?