search

cake-build / resources

Contains different kind of resources such as bootstrappers and configuration files.
MIT License
54 stars 79 forks source link

Flow tools, addins and modules paths from the botstrapper to cake.exe #57

Closed paulomorgado closed 3 years ago

paulomorgado commented 6 years ago

This change allows any change to the tools, addins or modules paths in the bootstrapper to flow to the invocation of cake.exe

gep13 commented 6 years ago

@paulomorgado @masterzdran these suggested changes would have quite far reaching additional changes in terms of documentation, and other parts of Cake (i.e. extensions, etc), so this is not something that will be pulled in immediately, if at all. We will need to discuss this within the team, alongside our other discussions about changes to bootstrappers, etc.

gep13 commented 6 years ago

@paulomorgado said... I understand that, @gep13 but, do you really think tools is such a unique name that will unlikely colide with other artifacts?

In the 4+ years that Cake has been an active project, I am only aware of 1 other person raising the naming convention of the tools folder as an issue. Once we provided the ability to configure the name of the tools folder, we haven't heard any other complaints/concerns until now.

paulomorgado commented 6 years ago

Fair enough, @gep13.

If I had asked people what they wanted, they would have said faster horses.

Henry Ford

😄

vpaulino commented 5 years ago

Naming environment variables according to the scope of their usage is important because it reduces the probabillity of name collisions from different ( tooling/sdk/thirth party libs or frameworks ) and software in that same environment. Now more then ever the usage of env variables is getting more relevant with software that runs on controlled environments such as docker containers... imagine now if another set of tools use the same env names that are not scoped? On the other end ... With the current namming convention Cake is only making sure that no other tool uses the name TOOLS ...wich is good then no other tool will make the same mistake ! :)

devlead commented 5 years ago

@vpaulino true.

That said all Cake related environment variables are prefixed CAKE_ so whilst there's a chance of collision there, it's not super likely.

Tools folder is the current convention, it's a suggestion and your free to change as you wish for your project.

With millions of builds done with Cake, where in general a bit hesitant to change defaults, as that might disrupt for more people than it benefits.

We've just got 2 requests in 4.5 years, so don't think it's a wide spread major issue.

pascalberger commented 3 years ago

We did some maintenance work on this repo which included removing of the develop branch which closed this PR.

As mentioned in previous comments it is unlikely that we switch names of folder, especially since in the meantime we recommend Cake .NET Tool. Feel free to start a new discussion if this is still an issue.