search

cake-contrib / Cake.Coveralls

Cake Addin that exends Cake with ability to push Code Coverage results to Coverall.io
https://cakebuild.net/extensions/cake-coveralls
MIT License
4 stars 10 forks source link

Re-Add Cake.Addin.Analyzer after it has been updated #155

Closed nils-a closed 4 months ago

nils-a commented 4 months ago

124 is going to remove the reference to Cake.Addin.Analyzer because it is no longer working correctly.

From the PR:

The package in question is indeed outdated; the latest version is 0.1.3, released on 03.03.21. I removed it due to its lack of support for .NET 6+, as critical errors were encountered during project solution upgrades. Consequently, it fails to analyze the Cake infrastructure accurately within the Visual Studio environment.

Once Cake.Addin.Analyzer has been successfully updated, we should re-add it to this solution.

nils-a commented 4 months ago

@raman-m sorry for nagging, again: Could you please elaborate a bit more on the problem with Cake.Addin.Analyzer?

I can see it working, no problems at all, in VS-2022, current VS-Code, and Rider-2024.1.4.

raman-m commented 4 months ago

Nils, I can't recall the specific reasons for disabling/commenting out the Cake.Addin.Analyzer package. It occurred three months ago when I initiated the PR. It's likely there were some conflicts with the CakeContrib.Guidelines library, suggesting a clash between certain rules. Allow me some time to review it again with the updated code in the develop branch.

Is this a significant issue preventing the release of v4?

P.S. FYI

The Cake.Addin.Analyzer package is not an official one; it is not part of the cake-contrib or cake-build accounts. The importance of this library varies for different users. If necessary, you should contact the library/repository owner to discuss updating the package with a new release.

raman-m commented 4 months ago

After adding the lib to the project, the VS build log is pretty clean: no messages. image

raman-m commented 4 months ago

VS Error List is also empty! image There are no messages whatsoever, indicating that it is safe to re-add the package.

nils-a commented 4 months ago

The analyzer provides two rules for things that were in the past often overlooked, but are really beneficial for how plugins/modules are listed on https://cakebuild.net. Hence, I'd rather have the analyzer in place than not.

So, thanks for confirming that there is no problem and for re-adding the analyzer. :pray:

The Cake.Addin.Analyzer package is not an official one; it is not part of the cake-contrib or cake-build accounts.

Well, no project in the cake-contrib org is in any way "official" - the org is meant to give a bit of structure to all the plugins "out there" and an additional layer of protection towards projects that might otherwise be lost (read: Projects where the owner never set a successor). We do not require plugins to be part of the cake-contrib org, nor do projects in the cake-contrib org have any special status compared to ones that are not part of the cake-contrib org.

nils-a commented 4 months ago

fixed in #165