cal-adapt / climakitae

A Python toolkit for retrieving, visualizing, and performing scientific analyses with data from the Cal-Adapt Analytics Engine.
https://climakitae.readthedocs.io
BSD 3-Clause "New" or "Revised" License
21 stars 2 forks source link

Bug Fix on TMY export for dataframe size #327

Closed vicford closed 8 months ago

vicford commented 8 months ago

Description of PR

Summary of changes and related issue The size of TMY dataframes prepared for export did not conform to the explicit standard of 8760 size. This was largely because of converting to local time producing a mismatch in hours. Several cases were then produced:

Relevant motivation and context

Dependencies required for this change? N/A

Fixes # (issue), delete if not necessary

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please run the typical_meteorological_year_methodology.ipynb notebook without making changes, and produce the resulting .epw and .tmy files. Please check that the files produced are 8760 in length for the data portion post header.

Checklist:

claalmve commented 8 months ago

Amazing, quick fixes for TMY! Really big kudos for getting this fix finished in such a time crunch 😄