Summary of changes and related issue
The size of TMY dataframes prepared for export did not conform to the explicit standard of 8760 size. This was largely because of converting to local time producing a mismatch in hours. Several cases were then produced:
An extra hour was included (size 8761)
A missing hour (size 8759)
Leap days were included if a model that has leap days had a Feb with a leap year selected (size 8784)
Leap days and a missing hour (size 8783)
Relevant motivation and context
Dependencies required for this change?
N/A
Fixes # (issue), delete if not necessary
Type of change
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please run the typical_meteorological_year_methodology.ipynb notebook without making changes, and produce the resulting .epw and .tmy files. Please check that the files produced are 8760 in length for the data portion post header.
[ ] Test A
Checklist:
[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[N/A] I have added tests that prove my fix is effective or that my feature works
[N/A] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules
Description of PR
Summary of changes and related issue The size of TMY dataframes prepared for export did not conform to the explicit standard of 8760 size. This was largely because of converting to local time producing a mismatch in hours. Several cases were then produced:
Relevant motivation and context
Dependencies required for this change? N/A
Fixes # (issue), delete if not necessary
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please run the
typical_meteorological_year_methodology.ipynb
notebook without making changes, and produce the resulting .epw and .tmy files. Please check that the files produced are 8760 in length for the data portion post header.Checklist: