Closed nicolejkeeney closed 1 month ago
Looks good to me! I just left a few small comments, but otherwise, the functionality of this PR looks great! Great work on such a big change in our codebase and including WL's in a much more consolidated format.
Description of PR
This branch of climakitae needs to be run with the corresponding branch of the same name in climakitaegui
Backend and front-end functionality added for retrieving based on warming levels or time based approach.
Eventually I think the goal is to move away from the warming levels explore module (?) since this functionality essentially duplicates that functionality within DataParameters object. Will need to discuss with the team what to do with the existing GUI functionality from warming.py since I believe having two similar but slightly different warming levels objects/functionality (i.e. ways to access data by warming level) will confuse users.
Notebook documentation should be updated to reflect this new functionality!
In a separate PR, I will update the functions in the
climakitae_direct_data_download.ipynb
notebook to reflect these new options and allow for users to use this approach without using the GUI or directly modifying theselections
object.Summary of changes and related issue
Lots of changes were made; I'll try to summarize as best as I can here.
DataParameters().approach
,DataParameters().warming_levels_window
,DataParameters().warming_levels_months
.Relevant motivation and context
Part of a larger effort to incorporate warming levels into AE stuff.
Type of change
Definition of Done Checklist
Practical
_
before the nameConceptual