cal-adapt / climakitae

A Python toolkit for retrieving, visualizing, and performing scientific analyses with data from the Cal-Adapt Analytics Engine.
https://climakitae.readthedocs.io
BSD 3-Clause "New" or "Revised" License
21 stars 2 forks source link

Adding WL 0.8 and 1.2 to existing GWL times files #460

Closed claalmve closed 3 days ago

claalmve commented 3 weeks ago

Description of PR

Summary of changes and related issue

This PR adds a 0.8 and 1.2 degC warming level to existing GWL tables and also removes some simulations that have NaNs at all WL's for a given simulation (iirc, that means that simulation's data cannot be found via our script for some reason).

Relevant motivation and context

We need 0.8 and 1.2 degC WL's.

Type of change


Definition of Done Checklist

Practical

Conceptual

claalmve commented 1 week ago

In this PR is an example usage of a constant WARMING_LEVELS in constants.py, that is then imported in data_interface.py. If this looks good, I can change all WL references to this WARMING_LEVELS reference in this PR.

nicolejkeeney commented 6 days ago

Was able to retrieve 0.8 and 1.2 in DataParameters GUI and get_data; and tests successfully ran on the Hub. I like the constants script, although I imagine we may have very few to put in there beyond WARMING_LEVELS, happy to defer to other dev opinions on that.

I'd like to see the SSP strings in the constants.py file if we chose to use this method of organizing constants (which I think is a good idea if we flesh it out more).

mdkoenig commented 6 days ago

Very demure, very DRY! <3