cal-itp / benefits

Transit benefits enrollment, minus the paperwork.
https://docs.calitp.org/benefits
GNU Affero General Public License v3.0
28 stars 9 forks source link

Update base Event to send transit_agency property #871

Closed thekaveman closed 2 years ago

thekaveman commented 2 years ago

Our core.analytics.Event class sets a provider_name event property AND user property to the (long) name of the user-selected Transit Agency. Since we only support a single Transit Agency right now, this property has seen limited use from the analysis/dashboarding side.

As we start to add some additional event properties e.g. in #342 - we should ensure all properties are named clearly. provider is used in other areas of our app (specifically the AuthProvider model) and could be confusing later on.

Unfortunately we have a bunch of events data in Amplitude already, and there's no way to update it. We could look at updating the ingestion pipeline in data-infra to transform that column name when we import into GCS/Warehouse/Metabase.

Acceptance Criteria

thekaveman commented 2 years ago

Merged the initial work in #901 to get the new property in there.

Still need to adjust the Tracking Plan, but we can probably not worry about backfilling/cleaning up our old data for now.