calebyyy / pe

0 stars 0 forks source link

Able to edit but not change anything #7

Open calebyyy opened 1 week ago

calebyyy commented 1 week ago

Able to have a successful edit command but not change a single field. By just copy n pasting values. Expect a error to be thrown as no field is changed.

Steps to reproduce:

  1. add n/John Doe p/98765432 e/johnd@example.com
  2. edit 1 n/John Doe p/98765432 e/johnd@example.com

Expected output: An error will be thrown Actual: Allowed to edit but not change anything as shown below Screenshot 2024-11-15 at 5.09.39 PM.png

soc-se-bot commented 1 week ago

Team's Response

I can agree that an error message can be thrown, but this change does not disrupt normal operations nor will the user intend to make this command anyway.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Hi I disagree with the dev team on why this is not in scope.

Screenshot 2024-11-19 at 12.40.43 PM.png

Based on the rulbrics. "if rectifying it is less important than the work that has been done already", the fix is to just have a simple check to ensure that at least one field is changed and hence does not require much effort. Furthermore this can cause additional bugs when more features are added and changed. Hence the fix is a simple one and should have been done when coding the edit feature. Therefore this is indeed a bug that should have been fixed. Furthermore the Dev team exaplanation is too little to justify the lack in scope.