Replaced deprecated set-output

calibreapp / image-actions

A Github Action that automatically compresses JPEGs, PNGs and WebPs in Pull Requests.

https://calibreapp.com/blog/compress-images-in-prs

GNU General Public License v3.0

1.42k stars 67 forks source link

Replaced deprecated set-output #258

Open lfgcampos opened 4 months ago

lfgcampos commented 4 months ago

What does this PR introduce?

fixes https://github.com/calibreapp/image-actions/issues/255

@benschwarz, I have to say I haven't tested it completely but the change seemed to be straightforward. Sorry if I am missing something easy/stupid here =)

Reviewers

@benschwarz

lfgcampos commented 2 months ago

hi @benschwarz, sorry to ping you on this but any news on it?

benschwarz commented 1 month ago

apologies for the delay @lfgcampos.

afaik you can use >> $GITHUB_OUTPUT (in bash) to push into the GITHUB_OUTPUT environment variable, but that isn't going to be a viable option from a node console log.

I think the path forward here would be to introduce @actions/core and the setOutput function, e.g.:

core.setOutput('markdown', escapedMarkdown);