calibreapp / image-actions

A Github Action that automatically compresses JPEGs, PNGs and WebPs in Pull Requests.
https://calibreapp.com/blog/compress-images-in-prs
GNU General Public License v3.0
1.42k stars 67 forks source link

fix: allow github action to work on external repos #259

Open ethanneff opened 3 months ago

ethanneff commented 3 months ago

👋🏻 Hi there!

This template will help you describe the work you’ve done, so one of the project owners can review and potentially accept it promptly. Please fill relevant sections below and feel free to delete what does not apply to your work (including this comment).

Thank you for helping us improve Image Actions! ⚡️


What does this PR introduce?

In a few bullet points, please describe the changes this Pull Request makes. E.g.:

Related issues

Are there any related issues or feature requests this work will resolve? Please mention them here. E.g.:

Learn more about linking Pull Requests to issues here.

Screenshots

If this work introduces any visual changes, add screenshots to portray them.

before (skipped workflow) | after (works) Screenshot 24

Reviewers

Mention one or more project owners here or request review directly in the right sidebar in the Reviewers section:

CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

benschwarz commented 3 months ago

Hey @ethanneff, thanks for the PR. Could you please sign the CLA and write a description of your changes and the motivations behind them?

At the moment the configuration you've changed is there purposefully to not optimize images on forked repositories. It would be good to hear why you think this behavior should be changed.