search

calico / basenji

Sequential regulatory activity predictions with deep convolutional neural networks.
Apache License 2.0
410 stars 126 forks source link

akita_data_read.py % string make target to zero #145

Closed r1cheu closed 1 year ago

r1cheu commented 1 year ago 
  File "akita_data_read.py", line 158, in main
    print("WARNING: %s >50% bins filtered, check:  %s. " % (genome_hic_file, mseq_str))
ValueError: unsupported format character 'b' (0x62) at index 17

hi, the code above will cause a ValueError, due to the except ValueError: below, will make the target to 0.

davek44 commented 1 year ago

I'm not sure that I understand. In your use case, does 'genome_hic_file' not contain a normal filename string?

r1cheu commented 1 year ago

just python recognize the % sign in the >50% bin as %b and casue valueerror.

davek44 commented 1 year ago

Ah, got it. I pushed a fix. Thanks!